feat: add write-coalesing to atx handling #6239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acud
force-pushed
the
write-coalesce-atxs
branch
from
96f52f0 to
23c07c0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6239 +/- ##
=======================================
Coverage 82.1% 82.1%
=======================================
Files 308 308
Lines 34123 34211 +88
=======================================
+ Hits 28026 28109 +83
- Misses 4321 4327 +6
+ Partials 1776 1775 -1 ☔ View full report in Codecov by Sentry. |
acud
force-pushed
the
write-coalesce-atxs
branch
from
2d87b5f to
7bbd507
Compare
4 tasks
|
closing in favor of #6257 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adds write-coalescing to leaf-atxs (that have no dependecies) written to DB from gossip and sync handlers without discrimination.
Description
WIP.
Adds support for write coalescing for ATXs coming in from gossip or sync. Right now trying to handle the case of ATXs that have no dependencies that need to be fetched from other peers simply due to the complexity of handling the other case, but hopefully I could manage to handle both cases in this PR.
Test Plan
TODO